Add bin/newver script for creating new Rubocop channels.
#129
Conversation
|
|
||
| ed Gemfile <<-EDITS | ||
| /gem "parser",/c | ||
| gem "parser" |
There was a problem hiding this comment.
is this replacing the line with the same line?
There was a problem hiding this comment.
It's replacing the version-specific line on master with one that doesn't specify a version. Master is pinned to an oddly-old parser, it seemed to me.
| gem "rubocop", "~> ${NEWVER}", require: false | ||
| . | ||
| wq | ||
| EDITS |
There was a problem hiding this comment.
TIL some ed basics, that's neat 👍
bin/newver
Outdated
| wq | ||
| EDITS | ||
|
|
||
| bundle update |
There was a problem hiding this comment.
should we do something more scoped like, bundle update rubocop?
There was a problem hiding this comment.
Note: in order for this to work, it would be necessary to add a make image before the ed line
There was a problem hiding this comment.
Whoops, this comment was meant to go on the thread about using docker, not the thread about scoping the bundle update 😅
bin/newver
Outdated
| wq | ||
| EDITS | ||
|
|
||
| bundle update |
There was a problem hiding this comment.
wdyt about doing this in docker? In general we try to avoid needing to have non-docker things installed on your host. We could do something like:
docker run --user root --rm --volume "$(pwd)":/usr/src/app --workdir /usr/src/app codeclimate/codeclimate-rubocop bundle update rubocopIn a lot of our code bases, we've added such a task to the Makefile as make bundle. If we did that, we might invoke it here as make bundle -e BUNDLE_ARGS='update rubocop'
There was a problem hiding this comment.
That seems like a nice improvement; I will change it to invoke docker like your example.
| retval=$? | ||
| if [ $retval -ne 0 ]; then | ||
| >&2 echo "If tests fail, you may need to modify spec/support/currently_undocumented_cops.txt" | ||
| exit $retval |
There was a problem hiding this comment.
this is a nice CLI UX 👏
* Make bundle uses docker, Following up on PR review and to be consistency with how we update gems in other repos
|
@maxjacobson I updated the script. I think it would be nice to merge this because it helps with releasing new versions. Can i get another review? |
* Add `bin/newver` script for creating new Rubocop channels. * Adds make bundle and updates newver script * Make bundle uses docker, Following up on PR review and to be consistency with how we update gems in other repos
* Add `bin/newver` script for creating new Rubocop channels. (#129) * Add `bin/newver` script for creating new Rubocop channels. * Adds make bundle and updates newver script * Make bundle uses docker, Following up on PR review and to be consistency with how we update gems in other repos * Updates rubocop-rspec 1.30
No description provided.