Skip to content

circleci: don't tag to git or deploy to docker hub #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2015

Conversation

wfleming
Copy link
Contributor

Doing all of this in Circle turned out to be a pain to get working correctly, and would have been even more of a pain to expand to other repos, so I'm backing out those bits.

Eventually, it would be good to have all of those various tasks centralized: once we do that elsewhere, we can remove the deployment bit entirely here. In the meantime, we should keep the existing behavior.

Doing all of this in Circle turned out to be a pain, so I'm backing out those bits.

Eventually, it would be good to have all of those various tasks centralized: once we do that elsewhere, we can remove the `deployment` bit entirely here. In the meantime, we should keep the existing behavior.
@pbrisbin
Copy link
Contributor

LGTM. Want to also add the notifications hook while you're in here?

@pbrisbin
Copy link
Contributor

wfleming added a commit that referenced this pull request Sep 1, 2015
circleci: don't tag to git or deploy to docker hub
@wfleming wfleming merged commit 06af4a9 into master Sep 1, 2015
@wfleming wfleming deleted the will/deploy-partial-revert branch September 1, 2015 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants