Migrate to circle2 #161
Merged
Migrate to circle2 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
maxjacobson
and removed request for
codeclimate-hermes
maxjacobson
reviewed
Mar 21, 2019
.circleci/config.yml
Outdated
| steps: | ||
| - checkout | ||
| - run: make image | ||
| - run: make citest |
There was a problem hiding this comment.
per the failing build, it looks like this should be make test
|
Sorry this is WIP, requested review too eagerly. Wrapping up one more thing. And yes to both things |
Old branches will need to cherry pick this commit
ale7714
commented
Mar 21, 2019
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Validate owner |
There was a problem hiding this comment.
circle 1 has this nice feature https://github.com/codeclimate/codeclimate-rubocop/blob/master/circle.yml#L24.
Unfortunately not available in circle2 so we're the validation within the job itself.
circleci step halt is a nifty trick to exit the job without failing the build. I learn it from this post.
maxjacobson
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old branches will need to cherry pick this commit