-
Notifications
You must be signed in to change notification settings - Fork 45
Expose docs generation through make #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hitting this error when I try to run this:
make docs
docker run --rm \
--workdir /usr/src/app \
--volume /home/max/src/cc/codeclimate-rubocop:/usr/src/app \
codeclimate/codeclimate-rubocop sh -c "bundle exec rake docs:scrape"
fatal: could not create work tree dir 'rubocop-git': Permission denied
sh: cd: line 1: can't cd to rubocop-git
not sure why...
Makefile
Outdated
@@ -2,6 +2,12 @@ | |||
|
|||
IMAGE_NAME ?= codeclimate/codeclimate-rubocop | |||
|
|||
docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think...
- this should depend on image (
docs: image
) - this should be added to the
PHONY
list at the top of the file - this shouldn't be the first task -- by convention, we always have
image
be the first task, somake
will default tomake image
.
The error is weird, went smooth for me. |
@maxjacobson Could it be some local permission not allowing the user within docker to write to the directory? |
@filipesperandio yeah I think so. Possibly a linux/mac difference. @wfleming perhaps you know the docker magic invocation to make this work? |
It's running as user id |
Cool, I can confirm that adding |
(Thanks @wfleming!) |
@maxjacobson @wfleming That works on mac too! 👍 |
No description provided.