This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Fix invocation error handling #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the `WithErrorHandling` middleware was changed to not return a hash of error information. This causes a bug since our consumer expects invocations to return either a Hash or `nil`. This patch updates the tests to assert that and fixes the bug.
|
Without this patch, the return value from an invocation in the case of an error would be the return value of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the
WithErrorHandlingmiddleware was changed to not return a hashof error information. This causes a bug since our consumer expects invocations
to return either a Hash or
nil.This patch updates the tests to assert that and fixes the bug.