This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Fix type inference for Password type #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikachu
force-pushed
the
fix-password-type
branch
2 times, most recently
from
1c3f132 to
d4f075e
Compare
|
Can we get a test for this? |
|
@brynary We sure can! Let me port this vague test case from codeclimate/codeclimate to here. |
The original type inference[1] uses `equal?` which returns `true` when any subclass, including `String`, is passed in. This fixes an issue when a `String` type is mistakenly marked as `Password` type when passed in. [1]: http://git.io/SXJanA
sikachu
force-pushed
the
fix-password-type
branch
from
d4f075e to
ca93171
Compare
|
@brynary I've updated the PR with test. Let me know what you think. |
|
As discussed in Slack, we'll roll out this change on codeclimate/codeclimate first, see if nothing breaks, then merge it. |
marshally
added a commit
that referenced
this pull request
Jan 20, 2015
Fix type inference for Password type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original type inference1 uses
equal?which returnstruewhen any subclass, includingString, is passed in. This fixes an issue when aStringtype is mistakenly marked asPasswordtype when passed in.