This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Relax activemodel dependency #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather wait for this until we know for sure that codeclimate/codeclimate runs on Rails 4+ |
|
This specification actually blocks codeclimate/codeclimate to be running on 4+ though. It's chicken and egg problem for sure. |
|
no really. Let's point your branch of codeclimate/codeclimate to this branch until we're sure that everything works as expected. This change can be merged once codeclimate/codeclimate has been successfully deployed using the branch as reference. |
|
Ah, I see. That can do. |
sikachu
force-pushed
the
ps-relax-dependency
branch
from
09888ed to
b122576
Compare
This will allow codeclimate-services to be used with Rails 4.x+
sikachu
force-pushed
the
ps-relax-dependency
branch
from
b122576 to
dc85a2c
Compare
|
Codeclimate is now running on Rails 4, and I've seen no issue so far. Merging this as it's blocking another ticket to go in. |
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow codeclimate-services to be used with Rails 4.x+