This repository was archived by the owner on Jul 19, 2025. It is now read-only.
return true when pull request commenting is enabled and a comment exists #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady exists Trello: https://trello.com/c/npDQ4rN3/103-record-response-from-sending-commit-status-instead-of-adding-comment-when-both-commit-status-and-comment-are-on fixes: #57 (diff) GithubPullRequests were mistakenly returning a false success code in the common case where a comment is already present on the pull request being updated. We should return a success instead.
marshally
force-pushed
the
pull_requests_return_true_if_comment_present
branch
from
70fd927 to
30e3f84
Compare
marshally
added a commit
that referenced
this pull request
Mar 20, 2015
…comment_present return true when pull request commenting is enabled and a comment exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/npDQ4rN3/103-record-response-from-sending-commit-status-instead-of-adding-comment-when-both-commit-status-and-comment-are-on
fixes: #57 (diff)
GithubPullRequestswere mistakenly returning a false success code in the common case where a comment is already present on the pull request being updated. We should return a success instead.