This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Show new PR status message only for repos with beta feature enabled #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codeclimate/review |
| @payload = payload.stringify_keys | ||
| @config = create_config(config) | ||
| @event = @payload["name"].to_s | ||
| def initialize(config, payload, beta_service_features) |
There was a problem hiding this comment.
Hmm. Not sure I like the name so much. How about something more along the lines of feature_toggle ? Whether its beta or not is sort of a separate concern.
There was a problem hiding this comment.
seems like the toggler could be an optional parameter
There was a problem hiding this comment.
I agree with the name change. I don't think it needs to be optional, because the app only instantiates this object in one place
|
LGTM other than reference to "beta" |
|
👍 |
iancanderson
force-pushed
the
ia-new-pr-status-only-for-repos-with-feature-flag
branch
from
61b1c57 to
57d2d60
Compare
iancanderson
added a commit
that referenced
this pull request
Apr 7, 2015
…os-with-feature-flag Show new PR status message only for repos with beta feature enabled
iancanderson
deleted the
ia-new-pr-status-only-for-repos-with-feature-flag
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also - use new nested hash structure to get issue counts from the event payload.
https://trello.com/c/f17uUGRd