This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Fix load-order dependency #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an `unitialized constant CC::Service::GitHubPullRequests`, which was happening if `CC::Service::GithubPullRequests::Presenter` was loaded before `CC::Service::GithubPullRequests`. Loading order is non-deterministic and can differ depending on OS, since services are loaded via `Dir[]`). Going forward, services that need a presenter class can require the presenter themselves.
| @@ -0,0 +1,62 @@ | |||
| module CC | |||
There was a problem hiding this comment.
This file was just moved from lib/cc/services to a new lib/cc/presenters directory, and nested under module CC and class Service, which is less susceptible to load order issues than doing class CC::Service::GithubPullRequestsPresenter
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an
unitialized constant CC::Service::GitHubPullRequests,which was happening if
CC::Service::GithubPullRequests::Presenterwas loadedbefore
CC::Service::GithubPullRequests. Loading order is non-deterministic andcan differ depending on OS, since services are loaded via
Dir[]).Going forward, services that need a presenter class can require the presenter
themselves.