This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Flag ignored service invocations #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://trello.com/c/1QAKfYtf Distinguish between service invocations that fail and service invocations that don't run because the service doesn't respond to an event without returning nil, since nil is an unexpected response in the middleware.
|
/cc @codeclimate/review |
|
👍 |
mrgilman
added a commit
that referenced
this pull request
Apr 14, 2015
Flag ignored service invocations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/1QAKfYtf
Distinguish between service invocations that fail and service
invocations that don't run because the service doesn't respond to an
event without returning nil, since nil is an unexpected response in the
middleware.