This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Remove rollout call for quality stats #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @codeclimate/review |
| @@ -13,7 +13,7 @@ def initialize(payload, repo_config) | |||
| end | |||
|
|
|||
| def success_message | |||
| if @repo_config.pr_status_quality_stats? | |||
| if issue_counts_in_payload? | |||
There was a problem hiding this comment.
Is this conditional still needed?
There was a problem hiding this comment.
The way these issues are passed and particularly how they are set in this class means they could be nil. I figured it was worth it to keep this check so that if the counts aren't in the request, we can still report statuses on github PRs.
There was a problem hiding this comment.
That might be vestigial. Are you aware of any cases where it makes sense that they'd be nil?
There was a problem hiding this comment.
Yeah. If we are the one controlling the message, I think this conditional is unnecessary. YAGNI.
|
👍 |
gdiggs
added a commit
that referenced
this pull request
Apr 20, 2015
Remove rollout call for quality stats
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this feature is enabled for all repos, we can remove the check