bump version

[ABaldwinHunter]

@codeclimate/review This PR bumps the Code Climate Services version from 0.1.0 to 0.2.0, after a change to services and finalizer that lets cc-services now receive an optional "messages" key on @payload - to provide clarity when analysis fails due to version incompatibility between snapshots. I have tested using the PR event trigger script in codeclimate-services.

The PR also makes minor updates to the pull request test, bringing over some clarifying instructions re OAUTH token from a same test in app.

If all looks well, I will bump the version and update codeclimate/app.

One note:
Intent of change was to make error messages more explicit and remove details link when comparisons fail due to analysis version incompatibility between snapshots.

Default error message:

Analysis fails due to analysis version incompatibility error message:

The lengths of these messages were calculated with the above space in mind. However, when CodeClimate is the only service someone is using (might be rare), the set up for checks is different and less room is available for message, leading to it getting cut off:

[gdiggs]

This should use a test repo as an example.

[ABaldwinHunter]

Thanks! Made switch to a test repo.

[gdiggs]

LGTM

[pbrisbin]

This doesn't seem right... is the script really invoked in this new manner?

[pbrisbin]

Actually are any changes to this script needed?

[pbrisbin]

To unpack this a little bit:

The script should work as-is with either version of the services gem, so no change should be needed. The idea is it's here with example values that you modify locally to test whatever it is you need to test. If we checked in those modifications every time, the script would see unnecessary churn.

We did identify that the OAUTH_TOKEN variable the script comment shows is a little mysterious, so I could see a change to further describe how to find a suitable value for that variable being valuable here.

[ABaldwinHunter]

Okay, makes sense. I'll keep a comment about OAUTH_TOKEN but revert the rest of script changes.

[pbrisbin]

I think you can revert the script changes, but the version bump LGTM.

[ABaldwinHunter]

@codeclimate/review Thanks for feedback. Ready for re-review.

I reverted all changes to the script except two. The PR still:

1. adds comment explaining github OAUTH_TOKEN source
2. adds key issue_comparison_counts to sample payload, which seemed necessary.

Without issue_comparison_counts, I got the following error:

Ashleys-MacBook-Pro:codeclimate-services ashleybaldwin-hunter$ bundle exec ruby pull_request_test.rb 
warning: ignoring extraneous `ruby-' prefix in version `ruby-2.0.0-p353'
         (set by /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/.ruby-version)
/Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/presenters/github_pull_requests_presenter.rb:26:in `each': undefined method `zero?' for nil:NilClass (NoMethodError)
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/presenters/github_pull_requests_presenter.rb:26:in `all?'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/presenters/github_pull_requests_presenter.rb:26:in `both_issue_counts_zero?'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/presenters/github_pull_requests_presenter.rb:16:in `success_message'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/services/github_pull_requests.rb:79:in `update_status_success'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/services/github_pull_requests.rb:52:in `receive_pull_request'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service.rb:86:in `public_send'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service.rb:86:in `block in receive'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service.rb:84:in `each'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service.rb:84:in `receive'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service/invocation.rb:41:in `block in initialize'
    from pull_request_test.rb:80:in `call'
    from pull_request_test.rb:80:in `call'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service/invocation/invocation_chain.rb:12:in `call'
    from /Users/ashleybaldwin-hunter/Desktop/code_climate/codeclimate-services/lib/cc/service/invocation.rb:45:in `initialize'
    from pull_request_test.rb:97:in `new'
    from pull_request_test.rb:97:in `<main>'

GitHubPullRequestPresenter expects there to be a key issue_comparison_count in payload. Not sure how that was left out before.

from github_pull_requests_presenter.rb:

module CC
  class Service
    class GitHubPullRequestsPresenter
      include ActiveSupport::NumberHelper

      def initialize(payload)
        issue_comparison_counts = payload["issue_comparison_counts"]

        if issue_comparison_counts
          @fixed_count = issue_comparison_counts["fixed"]
          @new_count = issue_comparison_counts["new"]
        end
      end

and presenter gets created in github_pull_requests.rb:

  def update_status_success
    add_comment
    update_status("success", presenter.success_message)
  end

  def update_status_failure
    add_comment
    update_status("failure", presenter.success_message)
  end

  def presenter
    CC::Service::GitHubPullRequestsPresenter.new(@payload)
  end

[pbrisbin]

LGTM