Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Add Issue type #79

Merged
merged 5 commits into from
Aug 25, 2015
Merged

Add Issue type #79

merged 5 commits into from
Aug 25, 2015

Conversation

gdiggs
Copy link
Contributor

@gdiggs gdiggs commented Aug 24, 2015

/cc @codeclimate/review

This adds an issue type for messages sent to external services. I chose to add this new type over adding to quality, as quality is already used for 2 things (rating changes and refactoring hot spots).

I realize there is a fair amount of duplicated code here - I'm open to ideas on how to fix that, but I'm not familiar enough with this codebase to make that call right now.

I skipped the following services, as they only deal with transitions:

  • Campfire
  • Flowdock
  • Hipchat
  • Slack

Preview on each service:

@pbrisbin
Copy link
Contributor

LGTM

gdiggs added a commit that referenced this pull request Aug 25, 2015
@gdiggs gdiggs merged commit 9433497 into master Aug 25, 2015
@gdiggs gdiggs deleted the gd-issue-tickets branch August 25, 2015 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants