This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Skip missing files in LCOV #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the formatter encounters an entry in the lcov report that does not exist in the file system it is skipped with a warning instead of dying with an exception.
|
Anything I need to change to get this merged? This issue is currently preventing any users of ember-cli from using code climate for test coverage reporting. |
|
👍 this change will unblock us from being unable to use codeclimate! |
|
@jrjohnson it might be useful to still die with an exception if every file does not exist? |
|
Looks good! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the formatter encounters an entry in the lcov report that does not exist in the file system it is skipped with a warning instead of dying with an exception.
In an ember-cli app the build step results in some files which do not exist in the source. These files end up with lcov entries, but should not result in breaking coverage reporting.