Raise better error when configuration is missing

[maxjacobson]

Thanks to @ABaldwinHunter for pairing on this

[maxjacobson]

@codeclimate/review WDYT about getting this change in before 1.0.0? I think it's a nice little improvement to the first-time user experience

[ABaldwinHunter]

LGTM

[wfleming]

Personal opinion: pry tends to sneak into dependencies for temporary debugging, but not actually be used long-term, so keeping it committed as a dev dependency doesn't feel appropriate.

[ABaldwinHunter]

Hm did a quick poll of some of our core services and we seem to have pry in slightly more than half:

builder, scheduler, api, cce: yes
wally, finalizer: no

Personally I'd be in favor. I see a benefit to having pry (find it useful when writing tests) and little downside.

Curious why you think it would

not actually be used long-term
?

[wfleming]

By "not used long term" I guess what I really mean is that it's rarely actually present in code. It's a console/slash debugging tool (e.g binding.pry). But those usages are quite possible by installing the gem globally & requiring it when you want it. Given how it's generally used, I don't think it's really a dependency of this project (or the others you mentioned), it's a developer tool that some people wanted to use & the Gemfile was a convenient way to load it.

On Sep 28, 2016, at 20:44, Ashley Baldwin-Hunter notifications@github.com wrote:

@ABaldwinHunter commented on this pull request.

In Gemfile:

@@ -5,5 +5,6 @@ gem "mocha"
gem "rake"
gem "simplecov"
gem "codeclimate-test-reporter", "1.0.0.pre.rc2"
+gem "pry"
Hm did a quick poll of some of our core services and we seem to have pry in slightly more than half:

builder, scheduler, api, cce: yes
wally, finalizer: no

Personally I'd be in favor. I see a benefit to having pry (find it useful when writing tests) and little downside.

Curious why you think it would

not actually be used long-term
?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[maxjacobson]

OK I'm going to call 🍍 and remove pry from this PR for now and encourage @ABaldwinHunter to open a new PR with pry. Personally I'm in favor of including it as well (in short: I think it needs to be in the Gemfile in order to require it when running tests via bundle exec rake, and for some reason running tests with simply rake currently fails for me locally so that's how I have to run it) but I'll leave that for another PR.