Skip to content

Fix for fatal in #13 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2014
Merged

Fix for fatal in #13 #14

merged 3 commits into from
Jul 22, 2014

Conversation

martinssipenko
Copy link
Contributor

PHP Fatal error:  Class 'Satooshi\Bundle\CoverallsV1Bundle\Config\Configuration' not found in /home/travis/build/sjparkinson/static-review/vendor/codeclimate/php-test-reporter/src/CodeClimate/Bundle/TestReporterBundle/CoverageCollector.php on line 22

#13

@sjparkinson
Copy link

👍 Would love to see this merged.

marshally added a commit that referenced this pull request Jul 22, 2014
@marshally marshally merged commit a59e7f8 into codeclimate:master Jul 22, 2014
@marshally
Copy link
Contributor

Merged.

Thanks @martinssipenko!

@martinssipenko
Copy link
Contributor Author

@marshally @mrb You need to bump version to 0.1.2 in order for this to work.

In addition to that, I think version 0.1.1 is not valid and should be deprecated and removed if possible, since it has a fatal error in it.

@marshally
Copy link
Contributor

I've bumped the version number to 0.1.2 in the master branch.

How would I go about removing 0.1.1?

On Wed, Jul 23, 2014 at 2:05 AM, Martins Sipenko notifications@github.com
wrote:

@marshally https://github.com/marshally @mrb https://github.com/mrb
You need to bump version to 0.1.2 in order for this to work.

In addition to that, I think version 0.1.1 is not valid and should be
deprecated and removed if possible, since it has a fatal error in it.


Reply to this email directly or view it on GitHub
#14 (comment)
.

@martinssipenko
Copy link
Contributor Author

@marshally
You can just remove git tag by running:

$ git push origin :v0.1.1 --tags
$ git tag -d v0.1.1

Then go to your packagist page https://packagist.org/packages/codeclimate/php-test-reporter and delete version v0.1.1

Also, I think you forgot to actually tag the master branch, you can do it by going to https://github.com/codeclimate/php-test-reporter/tags/new and adding a new v.0.1.2 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants