Ability to provide clover.xml location as input argument #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $config->addCloverXmlPath($rootDir . DIRECTORY_SEPARATOR . static::RELATIVE_PATH); | ||
| $this->setCloverPaths($paths); | ||
| foreach ($this->getCloverPaths() as $path) { | ||
| $config->addCloverXmlPath($rootDir . DIRECTORY_SEPARATOR . $path); |
There was a problem hiding this comment.
I would either check here and handle absolute paths correctly, or document explicitly in the option help that it should be relative.
|
Thanks @martinssipenko. We did some shuffling of GH teams and I lost write access to this Repo. Once I get that straightened out, I'll merged this. |
pbrisbin
added a commit
that referenced
this pull request
Jul 14, 2014
Ability to provide clover.xml location as input argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4