Skip to content

Update packaging instructions #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2017
Merged

Update packaging instructions #53

merged 3 commits into from
Mar 15, 2017

Conversation

dblandin
Copy link
Contributor

  • Require LABEL maintainer instead of MAINTAINER (deprecated)
  • Update Dockerfile example

dblandin added 2 commits March 14, 2017 22:10
@dblandin
Require LABEL maintainer instead of MAINTAINER (deprecated)
f6f5baf 
Before:

```
MAINTAINER "Your Name"
```

After:

```
LABEL maintainer "Your Name <you@example.com>"
```
@dblandin
Update Dockerfile example
4855ee2 
- Explicit image tag
- Alpine image
- `maintainer` LABEL
- Caching of dependencies
wfleming
wfleming approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@wfleming wfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this merits a bump on the patch number of the spec version.

@dblandin dblandin merged commit 25436bb into master Mar 15, 2017
@dblandin dblandin deleted the devon/update-packaging-instructions branch March 15, 2017 15:14
@dblandin dblandin mentioned this pull request Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfleming wfleming wfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblandin @wfleming