Agnostic support for CI systems

[adiroiban]

This is a follow up for buildbot/buildbot#1671

I see the code from https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L260-L430 is trying to hunt each CI system and extract the required information .

I don't see any generic lookup for those environment variables ... other than the token.

Those variables should also be VCS agnostic ... but for now this is of lower priority, since only GitHub/GitLab and Bitbucket are supported anyway.

The goal is to allow sending reports from Buildbot or other CI system without requiring to update codecov-python for each new CI system.

For my project I am using this environment in Buildbot https://github.com/chevah/buildbot-configuration-builder/blob/master/chevah/buildbot_configuration_builder/builder.py#L859

---

As agnostic environment variables I suggest:

commit -> VCS_COMMIT_ID
branch -> VCS_BRANCH_NAME
branch_url -> VCS_BRANCH_URL
build -> VCS_BUILD_ID
build_url -> VCS_BUILD_URL
pr -> GITHUB_PR_ID | GITLAB_PR_ID
slug -> GITHUB_SLUG | GITLAB_SLUG

---

any CI system should set CI=true and maybe 'CI_NAME=service`

[stevepeak]

Hey! I'll be adding these patterns below if no CI provider is found

  commit="$VCS_COMMIT_ID"
  branch="$VCS_BRANCH_NAME"
  build_url="$VCS_BRANCH_URL"
  build="$VCS_BUILD_ID"
  pr="$VCS_PULL_REQUEST"
  slug="$VCS_SLUG"

CI names are specific to our backend because of icons and internal database linkage.

[adiroiban]

I think that instead of

build -> VCS_BUILD_ID
build_url -> VCS_BUILD_URL

we should have

build -> CI_BUILD_ID
build_url -> CI_BUILD_URL

as these variables are related to the CI system and not with the VCS

[stevepeak]

Good point :) I agree with that 👍 I'll adjust accordingly

[jayvdb]

This is solved?

[stevepeak]

Short answer: Yes, in the bash uploader, when on CI provider is discovered.

Taking another look at it and I think we need to always collect these details, by default, regardless or CI detection.

[jayvdb]

It looks like there were commits in the python uploader as well. Is that work in the python uploader not complete?

[stevepeak]

I'll take a look at the python uploader too. Thank you

[thomasrockhu]

This has been solved via 2f3d3ab