Fix for issue #2 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumbed sbt.version -> 0.13.7
added correct prefixes to the coverage plugin settings corrected the coverage plugin config attribute names
corrected the travis-ci settings to use codecov
corrected the example .travis.yml settings
|
We are moving towards our python uploader (its basically the same as the Bash, but some customers don't liking checking in the bash file in to their config). Both uploaders are supported, just a preference. Thank you for the RP @pnerg I appreciate your help on fixing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to fix issue #2
I've done some modifications to the example settings in order to make it work.
Primarily it's the build.sbt file as the settings for coverage plugin were renamed starting from v1.x.
Also I believe the setting instrumentSettings should be removed.
I've also bumbed the sbt version to a later one, not sure if that really was necessary but I use that version and it works for me...:)
The .travis.yml and the README.md has been updated to reflect the settings needed.
Seems they renamed scoverage:test to be coverage test.
At least that's how they document the plugin.
Unfortunately I can't test this fully since travis-ci won't pick up my fork but it should work as the settings are pretty much the same as my working project. Apart from me using a newer version of Scala.
The .gitignore is a bonus...:) I'm too lazy to keep manually adding all files I want to commit so I added a "default" Scala .gitignore