Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out isBlacklisted #276

Closed
wants to merge 1 commit into from

Conversation

mitchell-codecov
Copy link
Contributor

@mitchell-codecov mitchell-codecov commented Aug 4, 2021

Closes #155
Closes #275

@mitchell-codecov mitchell-codecov requested a review from a team as a code owner August 4, 2021 18:19
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #276 (553cebb) into master (7556f45) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   87.68%   87.87%   +0.19%     
==========================================
  Files          24       24              
  Lines         861      858       -3     
  Branches      165      165              
==========================================
- Hits          755      754       -1     
+ Misses         35       33       -2     
  Partials       71       71              
Flag Coverage Δ
alpine 87.87% <ø> (+0.19%) ⬆️
linux 87.87% <ø> (+0.19%) ⬆️
linux-without-git 87.87% <ø> (+0.19%) ⬆️
macos 87.87% <ø> (+0.19%) ⬆️
macos-without-git 87.87% <ø> (+0.19%) ⬆️
windows 87.87% <ø> (+0.19%) ⬆️
windows-without-git 87.87% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.ts 91.93% <ø> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7556f45...553cebb. Read the comment docs.

@drazisil-codecov
Copy link
Contributor

Can you double-check the tests? I cant remember if we have a test to make sure a file does not appear in the listing.

@mitchell-codecov
Copy link
Contributor Author

Superseded by #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isBlacklisted is no longer used isBlacklisted() does not work for glob patterns
2 participants