Opcache: added version and bin to drupal8,9 and localgov tempaltes #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated package.json version: 1.1.19
#89) (#91) * #CE-62820: Added support for composer '2.x' in Drupal 9 provision template. * #CE-62820: Attempt to fix pull request test cases by providing a default value for the 'new_user' in provision. * #CE-62820: Attempt to fix pull request test cases by providing a default value for the 'key_name' in provision. * #CE-62820: Attempt to fix pull request test cases by providing a default values for 'ce_deploy' in provision. Co-authored-by: David Suissa <david.suissa@codeenigma.com> Co-authored-by: David Suissa <david.suissa@codeenigma.com>
* Adding a Drupal 9 template to ce-dev. * Testing nodejs version change with blank template. * Incrementing version for release. * There's no drupal9 template for ce-deploy.
* Renamed the settings and drush files for ce-dev * Added nodejs 16.x as default version * Added lhci_run role by default * Some tweaks in the config * Added the if statement to read info from an optional settings.local.php file
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [moment](https://github.com/moment/moment) from 2.27.0 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.27.0...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gregharvey
reviewed
Dec 30, 2022
| @@ -35,6 +35,10 @@ | |||
| no_dev: false | |||
| working_dir: "{{ deploy_path }}" | |||
| apcu_autoloader: false | |||
| - drush: | |||
| use_vendor: true | |||
| - drush_bin: "{{ deploy_path }}/vendor/drush/drush/drush" | |||
There was a problem hiding this comment.
Is this better as vendor/bin/drush?
There was a problem hiding this comment.
without {{ deploy_path }} we have to play with '../../../vendor........'
| @@ -41,10 +41,10 @@ jobs: | |||
| git clone https://github.com/codeenigma/wikis2pages.git | |||
| cd wikis2pages | |||
| /bin/bash init.sh https://${{ secrets.GITHUB_TOKEN }}@github.com/codeenigma/ce-dev.git 1.x | |||
| /bin/sh set-current.sh ce-dev-1.x | |||
| /bin/sh set-current.sh ce-dev-local | |||
There was a problem hiding this comment.
devel branch seems outdated if you compare with 1.x. The feature branch was created from 1.x.
https://github.com/codeenigma/ce-dev/blob/1.x/.github/workflows/ce-dev-publish-docs.yml#L44
| @@ -42,6 +42,7 @@ | |||
| # Create a list of URLs to test with LHCI | |||
| test_urls: | |||
| - "https://{{ _domain_name }}" | |||
| - cachetool_bin: "/usr/local/bin/cachetool" | |||
There was a problem hiding this comment.
This could be /home/ce-dev/.bin/cachetool I think? But maybe not with ce-provision defaults - worth checking?
There was a problem hiding this comment.
I tried with it actually, but for some reason the .bin/cachetool.phar is always the latest version of opcache. I don't know who/what installs this phar , maybe it is part of Debian Bullseye?
…ese don't have ce-deploy installed
…plates, these don't have ce-deploy installed
|
Kudos, SonarCloud Quality Gate passed!
|
|
This is no longer required, ce-provision handles the correct opcache version for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.