Bug fix: "execute" type checking #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? |
|
@sedlukha Please fix the conflicts |
check this out |
|
Guys, please merge this PR |
|
The merge is really needed. On slow connection, "TypeError: window.grecaptcha.execute is not a function" is always thrown. It seems that the ReCaptcha component is rendered before the library is actually ready to be used. |
|
Are you planning to release a 1.0.3 version on npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug if you try to load the page with reCaptcha after hard refresh:
Not sure about the reason for this problem, but everything works fine after "execute" type checking.