Some critical fixes #1

Kutashov · 2017-11-18T20:48:05Z

Good day!

Found your project. It seems good, except some embarrassing bugs. I'll be glad to make some improvements.

try-catch block was mistakenly placed out of socket.connect runnable

If the socket was not connected, exception was raised. Need to add some check

If the socket was not connected, disconnect call raise the exception. Need if statement

codeestX · 2017-11-19T06:48:50Z

@Kutashov Thank you very much!

Kutashov · 2017-11-19T07:18:35Z

You are welcome! Will a new version be available in jitpack?

codeestX · 2017-11-19T08:34:13Z

Done. 😄

compile 'com.github.codeestX:RxSocketClient:v1.0.1'

Kutashov added 3 commits November 18, 2017 22:58

Fix wrong exception handling

9052a43

try-catch block was mistakenly placed out of socket.connect runnable

Fix socket not connected exception

23c7df5

If the socket was not connected, exception was raised. Need to add some check

Fix UninitializedProperty exception

5029365

If the socket was not connected, disconnect call raise the exception. Need if statement

codeestX merged commit 140e888 into codeestX:master Nov 19, 2017

Provide feedback