Skip to content

Conversation

codefiesta
Copy link
Owner

Description

Converts the NetworkMonitor to @Observable and removes the Combine publishers to rely on network state changes. The NetworkMonitor now has an start() async method that asynchronously iterates through the internal NWPathMonitor NWPath elements as it conforms to AsyncSequence.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codefiesta codefiesta self-assigned this Jul 1, 2025
@codefiesta codefiesta added the enhancement New feature or request label Jul 1, 2025
@codefiesta codefiesta marked this pull request as ready for review July 1, 2025 17:45
@codefiesta codefiesta merged commit a0a1c53 into main Jul 1, 2025
2 checks passed
@codefiesta codefiesta deleted the network_monitor_async_sequence branch July 1, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant