Skip to content

Conversation

codefiesta
Copy link
Owner

@codefiesta codefiesta commented Jul 11, 2025

Description

  • NetworkMonitor is now a singleton as it doesn't make sense to multiple instances running inside the same container.
  • NetworkMonitor is now conforming to Sendable to safely pass from one concurrency domain to another.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codefiesta codefiesta self-assigned this Jul 11, 2025
@codefiesta codefiesta added the enhancement New feature or request label Jul 11, 2025
@codefiesta codefiesta marked this pull request as ready for review July 11, 2025 16:50
@codefiesta codefiesta merged commit 0e291cd into main Jul 11, 2025
3 checks passed
@codefiesta codefiesta deleted the network_monitor_singleton branch July 11, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant