Skip to content

Conversation

codefiesta
Copy link
Owner

Description

Encodes the /token urls as 'application/x-www-form-urlencoded' to be compliant with Microsoft OAuth2 endpoints.
Regression testing performed on Github & Google providers.

Shout out to this artticle on Medium: Swift: How to create a HTTP POST request with “application/x-www-form-urlencoded” body for the solution

Fix: #35

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codefiesta codefiesta self-assigned this May 30, 2025
@codefiesta codefiesta added the bug Something isn't working label May 30, 2025
@codefiesta codefiesta marked this pull request as ready for review May 30, 2025 22:58
@codefiesta codefiesta merged commit 25ab795 into main May 30, 2025
3 checks passed
@codefiesta codefiesta deleted the microsoft branch May 30, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft OAuth2

1 participant