Skip to content

Conversation

codefiesta
Copy link
Owner

Description

Some providers (like Slack) can have multiple layers of authentication. For instance, to sign into Slack, you might first need to sign into Google or OKTA and then can proceed with exchanging a code for an authorization token. The OAWebViewCoordinator now checks to make sure we should actually try and exchange a code for a token by always checking if the url we are intercepting starts with the redirect uri first.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codefiesta codefiesta self-assigned this May 31, 2025
@codefiesta codefiesta added the bug Something isn't working label May 31, 2025
@codefiesta codefiesta marked this pull request as ready for review May 31, 2025 01:16
@codefiesta codefiesta merged commit 4d23300 into main May 31, 2025
3 checks passed
@codefiesta codefiesta deleted the redirect_check branch May 31, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant