Skip to content

Conversation

codefiesta
Copy link
Owner

@codefiesta codefiesta commented Jun 13, 2025

Description

Fixes #70

The OAWebView is now being explicitly initialized with an OAuth object. This change is intended to do the following:

  • Increase test code coverage
  • Reduce potential bugs and developer confusion over the magic of which OAuth configuration is being used inside the OAWebView.

⚠️ This is a breaking change that forces developers to change the following:

 WindowGroup(id: "oauth") {
    OAWebView()
}

to

 WindowGroup(id: "oauth") {
    OAWebView(oauth: oauth)
}

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codefiesta codefiesta self-assigned this Jun 13, 2025
@codefiesta codefiesta changed the title [WIP] Comparing Init Coverage & Configurability Options [WIP] OAWebView - Comparing Init Coverage & Configurability Options Jun 13, 2025
@codefiesta codefiesta changed the title [WIP] OAWebView - Comparing Init Coverage & Configurability Options OAWebView - Init with OAuth Jun 15, 2025
@codefiesta codefiesta added this to the 1.2.0 milestone Jun 15, 2025
@codefiesta codefiesta changed the title OAWebView - Init with OAuth [WIP] OAWebView - Init with OAuth Jun 15, 2025
@codefiesta codefiesta changed the title [WIP] OAWebView - Init with OAuth OAWebView - Init with OAuth Jun 15, 2025
@codefiesta codefiesta added the enhancement New feature or request label Jun 15, 2025
@codefiesta codefiesta marked this pull request as ready for review June 15, 2025 17:43
@codefiesta codefiesta added the ⚠️ breaking change Introduces a breaking change to the API. label Jun 15, 2025
@codefiesta codefiesta added the security Security related request or issue. PRs with this label will run CodeQL scans. label Jun 15, 2025
@codefiesta codefiesta changed the title OAWebView - Init with OAuth OAWebView Initializer Jun 15, 2025
@codefiesta codefiesta merged commit 87bcec5 into main Jun 15, 2025
3 checks passed
@codefiesta codefiesta deleted the oawebview_init branch June 15, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ breaking change Introduces a breaking change to the API. enhancement New feature or request security Security related request or issue. PRs with this label will run CodeQL scans.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAWebView Init
1 participant