Github Actions Setup assumes user has edited the toml file

[aseembits93]

User description

Github Actions Setup during init assumes user has changed the other formatter to one of their choice but the init hasn't exited yet. I added an optional argument which overrides the assert check for a valid formatter.

---

PR Type

• Enhancement

---

Description

• Introduce override_formatter_check parameter for GitHub Actions

• Update install_github_actions call in init function

• Modify parse_config_file to conditionally bypass formatter check

---

Changes walkthrough 📝

Relevant files

Enhancement

cmd_init.py Update GitHub Actions installation with override parameter codeflash/cli_cmds/cmd_init.py Pass override_formatter_check=True to install_github_actions Update install_github_actions signature with new parameter Propagate override parameter to parse_config_file call +3/-3      config_parser.py Enhance config parser to bypass formatter check conditionally codeflash/code_utils/config_parser.py Add override_formatter_check parameter to parse_config_file Wrap formatter-cmds assertion in conditional check Maintain existing config parsing and key conversion logic +7/-5

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Configuration Change The introduction of the override_formatter_check parameter in install_github_actions may affect existing workflows. Review the impact on the setup sequence and ensure that related tests cover this new branch. install_github_actions(override_formatter_check=True) Conditional Bypass The conditional check bypassing the formatter validation in parse_config_file requires careful verification. Confirm that this behavior is intended and does not hide configuration errors that could lead to misconfigurations. #see if this is happening during Github actions setup if not override_formatter_check: assert config["formatter-cmds"][0] != "your-formatter $file", ( "The formatter command is not set correctly in pyproject.toml. Please set the " "formatter command in the 'formatter-cmds' key. More info - https://docs.codeflash.ai/configuration" )

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Conditional override flag Conditionally pass the override flag based on the execution environment to avoid bypassing validation outside GitHub Actions. codeflash/cli_cmds/cmd_init.py [76] -install_github_actions(override_formatter_check=True) +install_github_actions(override_formatter_check=(os.getenv("GITHUB_ACTIONS") == "true")) Suggestion importance[1-10]: 7 __ Why: The suggestion dynamically sets the override flag based on the GITHUB_ACTIONS environment variable, which is useful for ensuring validations run appropriately; however, it introduces an external dependency (os.getenv) that must be managed, resulting in a moderate improvement.	Medium
Possible issue	Explicit config validation Replace the assert with an explicit conditional raise to ensure the configuration is validated in all runtimes. codeflash/code_utils/config_parser.py [89-93] -if not override_formatter_check: - assert config["formatter-cmds"][0] != "your-formatter $file", ( - "The formatter command is not set correctly in pyproject.toml. Please set the " - "formatter command in the 'formatter-cmds' key. More info - https://docs.codeflash.ai/configuration" - ) +if not override_formatter_check and config["formatter-cmds"][0] == "your-formatter $file": + raise Exception("The formatter command is not set correctly in pyproject.toml. Please set the 'formatter-cmds' key. More info - https://docs.codeflash.ai/configuration") Suggestion importance[1-10]: 7 __ Why: Replacing the assert with an explicit exception improves the reliability of error handling in production, ensuring that misconfigurations are clearly reported, although using a generic Exception may be less ideal.	Medium