-
Notifications
You must be signed in to change notification settings - Fork 20
Pytest discovery optimization #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, thank you!
Revert "implement suggestions" This reverts commit 8bd8068. first pass
8bd8068
to
ad9b306
Compare
This reverts commit ad9b306.
@KRRT7 you mentioned that there were some cases where you found the behavior is different. Can you make test cases for the failing cases and push here? Also, lets resolve and merge this quickly |
@alvin-r we can merge this as is, this doesn't cause the issues I commented on elsewhere and such can be merged cleanly, this already has a major performance boost, there's still work to be done but for now it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets go
User description
with these changes, the test discovery and test processing is almost as fast as multi processing process_test_files but with less overhead
this should supersede #58, this just implements what @alvin-r says there
PR Type
Description
Enhance parallel test discovery using multiprocessing
Add progress bar for discovery feedback
Refactor test processing with caching and deduplication
Update project version metadata
Changes walkthrough 📝
discover_unit_tests.py
Enhance parallel test discovery and caching logic
codeflash/discovery/discover_unit_tests.py
version.py
Update project version metadata
codeflash/version.py