Excise credit #186927846 #4418
Merged
Excise credit #186927846 #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embarnard
commented
Mar 26, 2024
embarnard
commented
Mar 26, 2024
embarnard
commented
Mar 26, 2024
embarnard
commented
Mar 26, 2024
embarnard
commented
Mar 26, 2024
jenny-heath
reviewed
Mar 26, 2024
embarnard
commented
Mar 28, 2024
| has_valid_ssn = primary.ssn.present? && !primary.has_itin? | ||
| has_valid_agi = direct_file_data.fed_agi <= (filing_status_mfj? || filing_status_hoh? ? 25_000 : 12_500) | ||
| has_valid_ssn && has_valid_agi | ||
| def disqualified_from_excise_credit_df? |
There was a problem hiding this comment.
niceee these are so much better
embarnard
force-pushed
the
excise-credit-#186927846
branch
from
f3bd708
to
fc85e4a
Compare
|
Heroku app: https://gyr-review-app-4418-4c80cf9ba51f.herokuapp.com/ |
jenny-heath
reviewed
Mar 28, 2024
Comment on lines
+245
to
+246
| max_credit = 100 | ||
| max_credit -= @intake.household_excise_credit_claimed_amt if @intake.household_excise_credit_claimed_yes? && @intake.household_excise_credit_claimed_amt.is_a?(Integer) |
jenny-heath
force-pushed
the
excise-credit-#186927846
branch
from
fc85e4a
to
cd9edf7
Compare
Co-authored-by: Jenny Heath <jheath@codeforamerica.org>
Co-authored-by: Martha Pidcock <mpidcock@codeforamerica.org>
jenny-heath
force-pushed
the
excise-credit-#186927846
branch
from
cd9edf7
to
27a7f95
Compare
jenny-heath
added a commit
that referenced
this pull request
Apr 12, 2024
2024-04-12 Last release of tax season 2024 * Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted (#4479) * Update GYR banner for closing season (#4473) * Always showing download button after April 25 #187355990 (#4481) * Post-Deadline notification (#4475) * Pre-Deadline notification (#4469) * truncate 3rd party designee name (#4462) * Change logic for Reminder notification (#4447) * Close fyst #187355990 (#4472) * Fix submission and skip flaky tests #187278919 (#4468) * Refine AZ excise credit #186927846 (#4418) * pre-populate w2 info (#4457) * Center content on desktop #186632607 (#4444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.