Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-4479-5c47e86d0c2c.herokuapp.com/ |
jnf
reviewed
Apr 12, 2024
| def perform(intake) | ||
| return unless notified_of_rejected_and_not_accepted(intake) | ||
|
|
||
| puts "gets here" |
jenny-heath
reviewed
Apr 12, 2024
| submission.efile_submission_transitions.map(&:to_state) | ||
| end.uniq | ||
|
|
||
| last_state = intake.efile_submissions.last.efile_submission_transitions.last.to_state |
There was a problem hiding this comment.
i think you can do intake.efile_submissions.last.current_state
mpidcock
approved these changes
Apr 12, 2024
Comment on lines
+11
to
+25
| ny_intakes = StateFileNyIntake.joins(efile_submissions: :efile_submission_transitions) | ||
| .where(efile_submission_transitions: { to_state: 'notified_of_rejection' }) | ||
| .where.not(id: StateFileNyIntake.joins(efile_submissions: :efile_submission_transitions) | ||
| .where(efile_submission_transitions: { to_state: 'accepted' }) | ||
| .select(:id)) | ||
| .distinct | ||
|
|
||
| az_intakes = StateFileAzIntake.joins(efile_submissions: :efile_submission_transitions) | ||
| .where(efile_submission_transitions: { to_state: 'notified_of_rejection' }) | ||
| .where.not(id: StateFileAzIntake.joins(efile_submissions: :efile_submission_transitions) | ||
| .where(efile_submission_transitions: { to_state: 'accepted' }) | ||
| .select(:id)) | ||
| .distinct | ||
|
|
||
| ny_intakes.to_a + az_intakes.to_a |
There was a problem hiding this comment.
Instead of iterating over the state intake classes separates, some other new message implementations have been doing both at once using ApplicationRecord::STATE_INTAKE_CLASS_NAMES.each do |base_class| so that there aren't multiple blocks to maintain going forward. Something to consider doing here as well, but not blocking.
jenny-heath
reviewed
Apr 12, 2024
crontab
Outdated
| @@ -8,3 +8,5 @@ | |||
| */5 * * * * bundle exec rake worker_heartbeat:perform | |||
| */10 * * * * bundle exec rake efile:poll_and_get_acknowledgments | |||
| 0 17 * * * bundle exec rake state_file:reminder_to_finish_state_return | |||
| 0 14 13 4 * bundle exec rake send_reject_resolution_reminder_notifications:send | |||
| 0 14 22 4 * bundle exec rake send_reject_resolution_reminder_notifications:send | |||
embarnard
commented
Apr 12, 2024
crontab
Outdated
| @@ -8,3 +8,5 @@ | |||
| */5 * * * * bundle exec rake worker_heartbeat:perform | |||
| */10 * * * * bundle exec rake efile:poll_and_get_acknowledgments | |||
| 0 17 * * * bundle exec rake state_file:reminder_to_finish_state_return | |||
| 0 14 13 4 * bundle exec rake send_reject_resolution_reminder_notifications:send | |||
jenny-heath
reviewed
Apr 12, 2024
| namespace :send_reject_resolution_reminder_notifications do | ||
| desc 'Send reject resolution reminder notifications' | ||
| task 'send' => :environment do | ||
| BATCH_SIZE = 50 |
jenny-heath
approved these changes
Apr 12, 2024
| namespace :send_reject_resolution_reminder_notifications do | ||
| desc 'Send reject resolution reminder notifications' | ||
| task 'send' => :environment do | ||
| BATCH_SIZE = 50 |
embarnard
force-pushed
the
reject-resolution-msg-187355965
branch
from
87db214
to
c99ea3d
Compare
… been notified of rejection and not yet been accepted
embarnard
force-pushed
the
reject-resolution-msg-187355965
branch
from
c99ea3d
to
ba8acb2
Compare
jenny-heath
added a commit
that referenced
this pull request
Apr 12, 2024
2024-04-12 Last release of tax season 2024 * Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted (#4479) * Update GYR banner for closing season (#4473) * Always showing download button after April 25 #187355990 (#4481) * Post-Deadline notification (#4475) * Pre-Deadline notification (#4469) * truncate 3rd party designee name (#4462) * Change logic for Reminder notification (#4447) * Close fyst #187355990 (#4472) * Fix submission and skip flaky tests #187278919 (#4468) * Refine AZ excise credit #186927846 (#4418) * pre-populate w2 info (#4457) * Center content on desktop #186632607 (#4444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.