Post-Deadline notification #4475
Conversation
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
|
Heroku app: https://gyr-review-app-4475-ab50c51f4205.herokuapp.com/ |
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
| .where.not(email_address: nil) | ||
| .where.not(email_address_verified_at: nil) | ||
| .where(unsubscribed_from_email: false) | ||
| .where("#{base_class.underscore.pluralize}.message_tracker #> '{messages.state_file.post_deadline_reminder}' IS NULL") |
There was a problem hiding this comment.
Is this needed? I thought the send_only_once? config would take care of this.
There was a problem hiding this comment.
100% not needed; added for performance. Since intakes that have this message sent already anyway, I don't see why we should clog up system resources in DelayedJobs for emails that won't get sent anyway. Thinking forward for next years, this could be a TON of intakes that get loaded into memory for no reason. Thanks for bringing it up though.
| class_object = base_class.constantize | ||
| intakes_to_notify += class_object.left_joins(:efile_submissions) | ||
| .where(efile_submissions: { id: nil }) | ||
| .where("#{base_class.underscore.pluralize}.created_at < ?", cutoff_time_ago) |
There was a problem hiding this comment.
From reading the requirements, I don't think there is a cutoff for how long ago the intake was created. Only a cutoff for if they already got the reminder.
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
2024-04-12 Last release of tax season 2024 * Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted (#4479) * Update GYR banner for closing season (#4473) * Always showing download button after April 25 #187355990 (#4481) * Post-Deadline notification (#4475) * Pre-Deadline notification (#4469) * truncate 3rd party designee name (#4462) * Change logic for Reminder notification (#4447) * Close fyst #187355990 (#4472) * Fix submission and skip flaky tests #187278919 (#4468) * Refine AZ excise credit #186927846 (#4418) * pre-populate w2 info (#4457) * Center content on desktop #186632607 (#4444)
https://www.pivotaltracker.com/story/show/187355955