Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for Reminder notification #4447

Merged
merged 9 commits into from Apr 12, 2024

Conversation

rickreyhsig
Copy link
Contributor

Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Copy link

github-actions bot commented Apr 5, 2024

Heroku app: https://gyr-review-app-4447-acf6658ecb93.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4447 (optionally add --tail)

Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Ricardo Kreyhsig added 3 commits April 5, 2024 16:37
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Copy link
Contributor

@mpidcock mpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to consider

Ricardo Kreyhsig added 4 commits April 12, 2024 11:31
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
Co-authored-by: Ricardo Kreyhsig <rkreyhsig@codeforamerica.org>
@rickreyhsig rickreyhsig merged commit d0295c5 into main Apr 12, 2024
7 checks passed
@rickreyhsig rickreyhsig deleted the update_reminder_logic#187364441 branch April 12, 2024 14:48
jenny-heath added a commit that referenced this pull request Apr 12, 2024
2024-04-12 Last release of tax season 2024

* Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted (#4479)
* Update GYR banner for closing season (#4473)
* Always showing download button after April 25 #187355990  (#4481)
* Post-Deadline notification (#4475)
* Pre-Deadline notification (#4469)
* truncate 3rd party designee name (#4462)
* Change logic for Reminder notification (#4447)
* Close fyst #187355990 (#4472)
* Fix submission and skip flaky tests #187278919 (#4468)
* Refine AZ excise credit #186927846 (#4418)
* pre-populate w2 info (#4457)
* Center content on desktop #186632607 (#4444)
mpidcock added a commit that referenced this pull request Apr 13, 2024
jenny-heath pushed a commit that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants