Close fyst #187355990 #4472
Close fyst #187355990 #4472
Conversation
tofarr
commented
Apr 10, 2024
•
tofarr
commented
- Lots of copy updates in here
- Added before_action to redirect to either the return-status or the welcome page depending on whether a submission is present for the intake.
- Skipping the redirect for select pages
- Using sessions_toggle for checking dates (Making testing easier).
- Using different config for testing to prevent test failures after the closing day
|
Heroku app: https://gyr-review-app-4472-b1ac21ac9408.herokuapp.com/ |
|
Co-authored-by: Em Barnard-Shao ebarnard@codeforamerica.org |
| .question-layout .question-wrapper .button--primary.button--wide { | ||
| min-width: 40rem; | ||
| max-width: 40rem; | ||
| width: 40rem; |
There was a problem hiding this comment.
I noticed some text overflow on some buttons - making this a more generic rule allowed it to be reused. (Particularly in the different states of the return-status page)
| @@ -401,7 +401,7 @@ def open_for_ctc_read_write? | |||
| helper_method :open_for_ctc_read_write? | |||
|
|
|||
| def open_for_state_file_intake? | |||
| app_time.between?(Rails.configuration.state_file_start_of_open_intake, Rails.configuration.state_file_end_of_intake) | |||
| app_time.between?(Rails.configuration.state_file_start_of_open_intake, Rails.configuration.state_file_end_of_in_progress_intakes) | |||
There was a problem hiding this comment.
end_of_in_progress_intakes is a more descriptive standardized name
| @@ -106,6 +106,8 @@ | |||
|
|
|||
| # StateFile | |||
| config.state_file_start_of_open_intake = Time.find_zone('America/New_York').parse('2024-01-01 7:59:59') | |||
| config.state_file_end_of_new_intakes = Time.find_zone('America/New_York').parse('2038-04-15 23:59:59') | |||
| config.state_file_end_of_in_progress_intakes = Time.find_zone('America/New_York').parse('2038-04-25 23:59:59') | |||
There was a problem hiding this comment.
Setting this means that tests will not start failing on April 15
| <% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %> | ||
| <section class="spacing-below-15"> | ||
| <p class="spacing-below-5"><strong><%= t('.next_steps.can_edit.title') %></strong></p> | ||
| <%= @error.resolution(I18n.locale).present? ? @error.resolution(I18n.locale) : t('.next_steps.can_edit.body') %> |
There was a problem hiding this comment.
@tofarr from what tiffany said in slack I think we actually need to show the default text if its after this time so this <%= @error.resolution(I18n.locale).present? ? @error.resolution(I18n.locale) : t('.next_steps.can_edit.body') %> should actually be something more like this <%= @error.resolution(I18n.locale).present? && app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) ? @error.resolution(I18n.locale) : t('.next_steps.can_edit.body') %>
| @@ -39,20 +39,26 @@ | |||
| <% end %> | |||
There was a problem hiding this comment.
we should probably check the apptime for other places where we show the resolution like above on line 29 <% if @error&.resolution(I18n.locale)&.present? && app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) && !(@error&.auto_cancel || @error&.auto_wait) %> @tofarr
| require "rails_helper" | ||
|
|
||
| RSpec.describe StateFile::ReturnStatusController, type: :controller do | ||
| #TODO : set up the intake |
2024-04-12 Last release of tax season 2024 * Send reject resolution message on 4/13 and 4/22 for clients that have been notified of rejection and not yet been accepted (#4479) * Update GYR banner for closing season (#4473) * Always showing download button after April 25 #187355990 (#4481) * Post-Deadline notification (#4475) * Pre-Deadline notification (#4469) * truncate 3rd party designee name (#4462) * Change logic for Reminder notification (#4447) * Close fyst #187355990 (#4472) * Fix submission and skip flaky tests #187278919 (#4468) * Refine AZ excise credit #186927846 (#4418) * pre-populate w2 info (#4457) * Center content on desktop #186632607 (#4444)
