Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans code style of '/src/components' through 'Surrounder`. #1018 #1025

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Cleans code style of '/src/components' through 'Surrounder`. #1018 #1025

merged 1 commit into from
Nov 28, 2018

Conversation

knod
Copy link
Collaborator

@knod knod commented Nov 25, 2018

No description provided.

@knod knod requested a review from dylanesque November 25, 2018 04:53
dylanesque
dylanesque reviewed Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@dylanesque dylanesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why the function style in StepBar.js was changed. Is there a scoping issue?

@knod
Copy link
Collaborator Author

knod commented Nov 28, 2018

@dylanesque : Right now, our decision is to use arrow functions only when necessary.

@knod knod merged commit 15a2a67 into codeforboston:dev Nov 28, 2018
@knod knod deleted the clean-style-5 branch November 28, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanesque dylanesque dylanesque left review comments

@turnerhayes turnerhayes turnerhayes approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knod @turnerhayes @dylanesque