Hearing search index #1960
Open
Hearing search index #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jicruz96
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jicruz96
commented
Oct 4, 2025
| documentTrigger: "events/{eventId}", | ||
| alias: "hearings", | ||
| idField: "id", | ||
| filter: data => data.type === "hearing", |
There was a problem hiding this comment.
we only process events of type hearing
jicruz96
commented
Oct 4, 2025
| readonly documentTrigger: string | ||
| readonly idField: string | ||
| readonly convert: (data: DocumentData) => T | ||
| readonly filter?: (data: DocumentData) => boolean |
There was a problem hiding this comment.
documentTrigger /events/{eventId} is more than just hearings, so we add a filter to the search indexer config so we only process hearing events.
jicruz96
commented
Oct 4, 2025
There was a problem hiding this comment.
we create the helper .passesFilter() and refactor .syncDocument() to ensure it filters out events we don't want to include in search index
jicruz96
commented
Oct 4, 2025
Comment on lines
+71
to
+72
| number: doc.BillNumber, | ||
| slug: `${doc.GeneralCourtNumber}/${doc.BillNumber}` |
There was a problem hiding this comment.
saving both the bill number and the slug for a more ergonomic/performant browse hearings page later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles the backend search part of #1897
Steps to reproduce
yarn dev:up, wait for search-backfill to complete. should complete without error.yarn typesense-admin -e local console. In that console, runawait client.collections('hearings').retrieve()