This repository was archived by the owner on Mar 7, 2024. It is now read-only.
Add Circular Progress till the Firebase Data is fetched #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeenWarrior
suggested changes
Sep 21, 2020
| @@ -11,8 +11,8 @@ import { | |||
| } from 'src/actions/accountActions'; | |||
|
|
|||
| const initialState = { | |||
| user: null, | |||
There was a problem hiding this comment.
why null was not working for you?
There was a problem hiding this comment.
I got it bit late but we have three states:
- null: The user is not logged In
- [Object Object] : The user is logged and have its object like uid and more
- Undefined: The data is yet not fully fetched from the firebase to guess if it is loogedIn/Not
| {user === undefined ? ( | ||
| <CircularProgress size="24px" color="inherit" /> | ||
| ) : ( | ||
| <Typography variant="h6">Login / Sign Up</Typography> |
There was a problem hiding this comment.
Shift it back to just Login
Abhishek-kumar09
force-pushed
the
master
branch
from
b80d721 to
d68bcf0
Compare
Abhishek-kumar09
force-pushed
the
master
branch
from
d68bcf0 to
52c30d7
Compare
KeenWarrior
approved these changes
Sep 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
Added Circular Bar till the user is confirmed to be logged in / Not.
See the effect on refreshing the browser again and again.