Skip to content
This repository was archived by the owner on Mar 7, 2024. It is now read-only.

Conversation

Saif807380
Copy link
Contributor

No description provided.

Copy link
Contributor

@Abhishek-kumar09 Abhishek-kumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else is great, just a minor suggestion.

validators={['required']}
errorMessages={['This is a required field']}
validators={['required', 'matchRegexp:^[+]*[(]*[+]{0,1}[0-9]{1,3}[)]{0,1}[-s./0-9]*$']}
errorMessages={['This is a required field', 'Please enter a valid contact number']}
/>
Copy link
Contributor

@Abhishek-kumar09 Abhishek-kumar09 Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work @Saif807380,
We can nest two form fields (<SelectValidator /> and this <TextValidator>) inside a fragment or grid, to give the user an option to select the country code.
For now we could map through an array of 1 to 100, (with default value 91) or use https://ipstack.com/

@Saif807380
Copy link
Contributor Author

Thanks for the review. I have added the country code dropdown. Link to preview. I have used an array for it as using ipstack.com would require getting an account and an API key.

Copy link
Contributor

@Abhishek-kumar09 Abhishek-kumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, its looking great!

@KeenWarrior KeenWarrior merged commit 8bb179a into codeforcauseorg:development Sep 23, 2020
@KeenWarrior
Copy link
Contributor

Thanks for great work @Saif807380

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants