Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the Application a PWA #213

Open
dhwaj1902 opened this issue Apr 5, 2021 · 9 comments
Open

Making the Application a PWA #213

dhwaj1902 opened this issue Apr 5, 2021 · 9 comments

Comments

@dhwaj1902
Copy link
Contributor

Currently, the application is running on a browser, but now I want to convert it to an app a PWA so that it can installable on the machine.

@dhwaj1902
Copy link
Contributor Author

dhwaj1902 commented Apr 5, 2021

@Abhishek-kumar09 I am facing an issue while creating a Pull Request, I rebase my currently forked main branch with upstream/main breach, but it is still showing this.

image

and when I create a pull request it shows my previous commits like:

image

I also create new branches but they all are showing this.

Please Help me regarding this issue.

@dhwaj1902
Copy link
Contributor Author

And also can you please review my issue also @Abhishek-kumar09, regarding PWA.

@dhwaj1902
Copy link
Contributor Author

@kunal-kushwaha @KeenWarrior please help 🙏.

@ADRE9
Copy link
Contributor

ADRE9 commented Apr 6, 2021

Hey @dhwaj1902 actually this react app is gonna be converted to an apk file using the Capacitor js library. So you don't have to make it as a PWA.

@dhwaj1902
Copy link
Contributor Author

Ok, I understand that but what about this issue? I am not able to make any or any commit because this is showing.

@rizwan2000rm
Copy link
Contributor

rizwan2000rm commented Apr 7, 2021

@dhwaj1902 Please look into advance git functionality. You might have to hard reset to a previous commit and merge with a rebase rather than a commit.

@ADRE9
Copy link
Contributor

ADRE9 commented Apr 7, 2021

I guess each time you pull from the upstream you commit with a message and push so it takes it as an update and shows that your branch is ahead of the forked project. So after pulling simple push without commiting to bring your GitHub repo equal to the project repo. Hope this will help you in future.

@dhwaj1902
Copy link
Contributor Author

@ADRE9 I did the same but it is still showing like this.
image

@Abhishek-kumar09
Copy link
Contributor

Hi, @dhwaj1902

To delete those extra commits and make your branch even with main branch, Do rebasing.

git rebase -i HEAD~5 // 5 being the number of commits to look into an interactive terminal
now delete the commits that you dont want by replacing "pick" with "drop"
Once done, press "ctrl+s and then ctrl+x"
Your branch is rebased and is now even with the main branch of edu-clent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants