Skip to content

Add Prettier and Eslint linting and apply it. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Add Prettier and Eslint linting and apply it. #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
02a8eaf
Add Prettier and Eslint linting and apply it.
jhoover4 Jun 11, 2023
5825ac9
Apply eslint fixes.
jhoover4 Jun 11, 2023
504e8e9
Revert app test from commented out.
jhoover4 Jun 11, 2023
5d347b0
Update eslint config to use create react app config correctly.
Jun 12, 2023
4c20b35
Remove eslint disable and re-run prettier.
Jun 12, 2023
80e03fd
Update .eslintrc.js
jhoover4 Jul 8, 2023
3bae9e6
Update src/components/Projects/chatGPT-Projects.html
jhoover4 Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
extends: ["react-app", "prettier"],
plugins: ["jsx-a11y"],
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the env section was removed (from here) - were these no longer needed?

Copy link
Author

@jhoover4 jhoover4 Jul 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that would be defining it twice. If we want to define that now we could do it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you think it's better to do it the other way (as is now in the code) then I'm good with keeping it like this

2 changes: 2 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
build
coverage
1 change: 1 addition & 0 deletions .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
66 changes: 49 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,11 @@
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
"eject": "react-scripts eject",
"format": "prettier --write ./src",
"lint": "eslint --fix src/**/*.{js,jsx}",
"format-check": "prettier --check ./src",
"lint-check": "eslint src/**/*.{js,jsx}"
},
"browserslist": {
"production": [
Expand All @@ -38,5 +36,11 @@
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"eslint": "^8.42.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-react": "^7.32.2",
"prettier": "2.8.8"
}
}
Loading