Improved support for DBCS output #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
There was a problem hiding this comment.
@worksofliam Looking good! 👍
I added a test for Danish characters in DB2 output, and the test succeeds.
@sebjulliand Can you add a test for French characters?
Signed-off-by: S. Julliand <sebjulliand@gmail.com>
|
@worksofliam @chrjorgensen there you go! |
sebjulliand
approved these changes
Apr 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Potential fix for #1984 where the columns were being parsed incorrectly and an incorrect amount of rows were being returned.
Nice to haves
It'd be cool if we had a test for some Danish and French locale results to test the parser as well.
How to test this PR
Examples:
Checklist
console.logs I added