Skip to content

Conversation

Nico385412
Copy link

@Nico385412 Nico385412 commented Nov 27, 2022

Hello 👋

I noticed the workflow does not work with repositories that contains uppercased chars.

I propose this PR which does the following:

  • remove the IMAGE_NAME from the hardcoded env variables
  • create an intermadiate step which get the repository and lowercase it, then push it to the GITHUB_ENV
  • Finally, use this env variable IMAGE_NAME in the Build and push Docker image step
  • (Bonus), use the REGISTRY env as well in the step, (ghcr.io was harcoded)

POC => https://github.com/Nico385412/gitops-cert-level-2-examples/actions/runs/3554828803

@Nico385412 Nico385412 changed the title fix(docker-publish): handle Uppecased chars repository fix(docker-publish): handle Uppercased chars repository Nov 27, 2022
@kostis-codefresh
Copy link
Member

Should be solved already by #66

Let us know if this doesn't work for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants