Skip to content

Support for k8s.io/ingress-nginx-codefresh controller #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Conversation

mikhail-klimko
Copy link
Contributor

@mikhail-klimko mikhail-klimko commented Jun 3, 2022

What:

PR adds k8s.io/ingress-nginx-codefresh as supported ingress controller type

Why:

Codefresh onprem installation (with Argo-Platform) by default deploys ingress-nginx controller (ref: https://github.com/kubernetes/ingress-nginx/tree/main/charts/ingress-nginx) with the following configuration:

ingress-nginx:
  enabled: true
  controller:
    ingressClassResource:
      enabled: true
      default: false
      controllerValue: "k8s.io/ingress-nginx-codefresh"
      name: nginx-codefresh

The goal is to make it possible to install Codefresh onprem (with Argo-Platfrom) and V2 runtime on the same cluster using the same ingress controller.

Notes:

CR-12013

@mikhail-klimko mikhail-klimko merged commit bec5aa1 into main Jun 6, 2022
@mikhail-klimko mikhail-klimko deleted the CR-12013 branch June 6, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants