CR-13046 cluster name bug #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotem-codefresh
requested review from
roi-codefresh,
noam-codefresh,
oren-codefresh,
pasha-codefresh and
ziv-codefresh
as code owners
cmd/commands/cluster.go
Outdated
| beginsWithNum := regexp.MustCompile(`^\d`) | ||
|
|
||
| if beginsWithNum.MatchString(name) { | ||
| name = fmt.Sprint("a", name) |
There was a problem hiding this comment.
what does that do? just add "a" at the beginning?
what if now the name is too long? why "a" and not anything else? why not just remove all digits in the prefix?
also - why not "a"+name?
cmd/commands/cluster.go
Outdated
Comment on lines
240
to
242
| if beginsWithNum.MatchString(name) { | ||
| name = beginsWithNum.ReplaceAllString(name, "") | ||
| } |
There was a problem hiding this comment.
what happens if you just run
name = beginsWithNum.ReplaceAllString(name, "")
wouldn't it just not do anything if there are no digits at the start?
noam-codefresh
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.