saas-1569 rework auth #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itai-codefresh
approved these changes
Feb 28, 2019
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM node:9.2.0-alpine | |||
| FROM node:10.13.0-alpine | |||
There was a problem hiding this comment.
9.2.0 was the previously used - let it stay the same
| @@ -15,7 +15,7 @@ steps: | |||
|
|
|||
| extract_version: | |||
| title: "Exporting package.json version" | |||
| image: codefresh/cli-build | |||
| image: codefresh/build-cli | |||
There was a problem hiding this comment.
what is this image?
There was a problem hiding this comment.
codefresh/build-cli is the image we provide instead of codefresh/cli-build - because we do not have any Dockerfile for it and cannot review or change it.
…when created from env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.