Feature/olegz/saas 5027 running pipeline only with yaml #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itai-codefresh
previously requested changes
Jan 20, 2020
| throw new CFError({ | ||
| message: `Passed pipeline id: ${pipelineName} does not exist`, | ||
| }); | ||
| const shadowRunning = userYamlDescriptor && !pipelineName; |
There was a problem hiding this comment.
why to handle this as an error? lets handle this as a normal flow
| const { debug, skip, only, trigger, cpu, memory, branch, sha, disk } = this.argv; | ||
| const { | ||
| debug, skip, only, trigger, cpu, memory, branch, sha, disk, shadowRunning, | ||
| } = this.argv; |
There was a problem hiding this comment.
why do we need the shadowRunning flag.
in case not passing pipeline name backend and cli should validated that the yaml file descriptor was passed, if not will throw an error
…ndefined` param, request sends like `/pipelines/run/,`
pasha-codefresh
approved these changes
Jan 21, 2020
yaroslav-codefresh
approved these changes
Jan 21, 2020
olegz-codefresh
deleted the
feature/olegz/SAAS-5027-running-pipeline-only-with-yaml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.