Skip to content

validate codefresh run trigger args #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2022
Merged

validate codefresh run trigger args #770

merged 4 commits into from
Dec 12, 2022

Conversation

kim-codefresh
Copy link
Contributor

No description provided.

@roi-codefresh
Copy link
Contributor

Use yargs: http://yargs.js.org/docs/#api-reference-checkfn-globaltrue
parse and validate the options at command level, not inside the logic it self

@kim-codefresh kim-codefresh merged commit a6c04ad into master Dec 12, 2022
kim-codefresh added a commit that referenced this pull request Dec 12, 2022
kim-codefresh added a commit that referenced this pull request Dec 12, 2022
* validate codefresh run trigger args

* validate the options at command level, instead inside the logic it self

* fix error msg

* trigger

* Revert "validate codefresh run trigger args (#770)"

This reverts commit a6c04ad.

* revert
kim-codefresh added a commit that referenced this pull request Dec 14, 2022
* validate codefresh run trigger args

* validate the options at command level, instead inside the logic it self

* fix error msg

* trigger

* Revert "validate codefresh run trigger args (#770)"

This reverts commit a6c04ad.

* revert

* add deprecation warnning msg

* fix warning msg

* remove deprecation info on help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants